1.5 Source control selection missing [Fixed]

Maru · May 3, 2018, 6:21am

After updating to 1.5 I saw that I was no longer able to select a source control provided by an extension.

source-control-missing

For testing I downgraded to 1.4 and was able to select one. After updating to 1.5 again I saw that it was now shown on the device setup and apparently working.

source-show

But when trying to delete the source control (clicking on the “x”) roon just crashed.
In the logs I found the following…

--[ BROOSCRIPT EXCEPTION ]-------------------------------------------

Exception Message: Property get not found on type Sooloos.Broker.Transport.RaatServerAudioDevice+Setup: remove_external_source_control



at ..\ui\device_setup.broo:0 [23174c:001f] action
--[ INNER EXCEPTION ]------------------------------------------------
Inner Exception Source:      Broo.Runtime
Inner Exception Type:        Broo.PropertyGetterNotFoundException
Inner Exception Target Site: Binding.GetMember
Inner Exception Message:     Property get not found on type 
Sooloos.Broker.Transport.RaatServerAudioDevice+Setup: 
remove_external_source_control
 Inner Exception Data:        none

--[ Inner Stack Trace ]------------
Broo.Runtime.Binding.GetMember(Value value, String name, Boolean isconstcontext)
   Broo.Runtime.DLL, IL 106, N 329
Broo.Runtime.Interpreter.Run(Scope scope, BrooxCode code, ArgList args, String name)
   Broo.Runtime.DLL, IL 3070, N 12099

--[ OUTER EXCEPTION ]------------------------------------------------
Outer Exception Source:      Broo.Runtime
Outer Exception Type:        Broo.BrooScriptException
Outer Exception Target Site: Interpreter.Run
Outer Exception Message:     Exception in brooscript
Outer Exception Data:        none

--[ Outer Stack Trace ]------------
 Broo.Runtime.Interpreter.Run(Scope scope, BrooxCode code, ArgList args, String name)
    Broo.Runtime.DLL, IL 4251, N 15707
 Broo.Runtime.Action/ActionScope.Run()
   Broo.Runtime.DLL, IL 40, N 83
Broo.Engine.Widget.TouchDone(TouchDoneEvent ev)
   BrooEngine.DLL, IL 160, N 329
Broo.Engine.TouchNode.DoTouchDone(HitList hits, TouchDoneEvent ev)
   BrooEngine.DLL, IL 113, N 294
Broo.Engine.Engine.ev_PrimaryMouseUp(Boolean shifted, Int32 x, Int32 y)
   BrooEngine.DLL, IL 102, N 188
Broo.Engine.OpenGlWindow.ev_ClickUp(Object o, MouseEventArgs e)
   BrooEngine.DLL, IL 78, N 120
System.Windows.Forms.Control.OnMouseUp(MouseEventArgs e)
   System.Windows.Forms.dll, IL 33, N 149
System.Windows.Forms.Control.WmMouseUp(Message& m, MouseButtons button, Int32 clicks)
   System.Windows.Forms.dll, IL 388, N 734
System.Windows.Forms.Control.WndProc(Message& m)
   System.Windows.Forms.dll, IL 1250, N 3041
System.Windows.Forms.Form.WndProc(Message& m)
   System.Windows.Forms.dll, IL 720, N 97
Broo.Engine.GlWindow.WndProc(Message& m)
   BrooEngine.DLL, IL 188, N 343
System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)
   System.Windows.Forms.dll, IL 37, N 195


05/03 08:12:58 Error: 
Local Time:            05/03/2018 08:12:58 +02:00
Device Serial Number:  135C06CA-B32C-4387-B4ED-C0FD53569154


Roon Version:       1.5 (build 320) stable

OS Version:            Windows 7

Application Domain:    Roon.exe

Assembly Codebase:     file:///C:/.................../Roon.exe

Assembly Full Name:    Roon, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null


--[ BROOSCRIPT EXCEPTION ]-------------------------------------------

Exception Message: Property get not found on type Sooloos.Broker.Transport.RaatServerAudioDevice+Setup: remove_external_source_control



at ..\ui\device_setup.broo:0 [23174c:001f] action

--[ INNER EXCEPTION ]------------------------------------------------
Inner Exception Source:      Broo.Runtime
Inner Exception Type:        Broo.PropertyGetterNotFoundException
Inner Exception Target Site: Binding.GetMember
Inner Exception Message:     Property get not found on type 
Sooloos.Broker.Transport.RaatServerAudioDevice+Setup: remove_external_source_control
Inner Exception Data:        none

   --[ Inner Stack Trace ]------------
 Broo.Runtime.Binding.GetMember(Value value, String name, Boolean isconstcontext)
   Broo.Runtime.DLL, IL 106, N 329
Broo.Runtime.Interpreter.Run(Scope scope, BrooxCode code, ArgList args, String name)
   Broo.Runtime.DLL, IL 3070, N 12099

--[ OUTER EXCEPTION ]------------------------------------------------
Outer Exception Source:      Broo.Runtime
Outer Exception Type:        Broo.BrooScriptException
Outer Exception Target Site: Interpreter.Run
Outer Exception Message:     Exception in brooscript
Outer Exception Data:        none

 --[ Outer Stack Trace ]------------
 Broo.Runtime.Interpreter.Run(Scope scope, BrooxCode code, ArgList args, String name)
   Broo.Runtime.DLL, IL 4251, N 15707
 Broo.Runtime.Action/ActionScope.Run()
   Broo.Runtime.DLL, IL 40, N 83
 Broo.Engine.Widget.TouchDone(TouchDoneEvent ev)
   BrooEngine.DLL, IL 160, N 329
 Broo.Engine.TouchNode.DoTouchDone(HitList hits, TouchDoneEvent ev)
   BrooEngine.DLL, IL 113, N 294
 Broo.Engine.Engine.ev_PrimaryMouseUp(Boolean shifted, Int32 x, Int32 y)
   BrooEngine.DLL, IL 102, N 188
 Broo.Engine.OpenGlWindow.ev_ClickUp(Object o, MouseEventArgs e)
   BrooEngine.DLL, IL 78, N 120
System.Windows.Forms.Control.OnMouseUp(MouseEventArgs e)
   System.Windows.Forms.dll, IL 33, N 149
System.Windows.Forms.Control.WmMouseUp(Message& m, MouseButtons button, Int32 clicks)
   System.Windows.Forms.dll, IL 388, N 734
System.Windows.Forms.Control.WndProc(Message& m)
   System.Windows.Forms.dll, IL 1250, N 3041
System.Windows.Forms.Form.WndProc(Message& m)
   System.Windows.Forms.dll, IL 720, N 97
Broo.Engine.GlWindow.WndProc(Message& m)
   BrooEngine.DLL, IL 188, N 343
System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)
   System.Windows.Forms.dll, IL 37, N 195

Maru · May 3, 2018, 6:25am

Additionally I saw that the volume control dropdown does not show the correct entry when an external control is selected.

selected-volume

As you can see I choose the external one but after that I see this.

shown-volume

It does work though.

ivan · May 3, 2018, 8:08am

Hi, @Maru, thanks for the report! We’ll look into this behavior. By the way, which Meridian gear do you have ?

Thanks!

–
Ivan

Maru · May 3, 2018, 8:19am

I just used the meridian extension as an example. Personally I use this.

But this is using the same Roon-API calls as the meridian one so has the same issues.

ivan · May 3, 2018, 8:45am

Thanks, we’ll try to reproduce this internally, @Maru!

–
Ivan

Maru · May 3, 2018, 4:19pm

I tried it on my rock now and not surprising the app crashed there as well (on the rock) as soon as trying to remove the control.

Maru · May 3, 2018, 6:47pm

Ok, so now I have ROCK running with 1.5 and i haveone remote still running with 1.4. If I try to make changes to the source control with this remote it works, so it really just seems to be an UI issue in the ui*.broox files.

ivan · May 3, 2018, 11:46pm

@Maru, thanks for your observations, we put a ticket for our dev team!

–
Ivan

mike · May 4, 2018, 3:31am

Hey @Maru – we did find some issues here, sorry for the trouble.

We’ll be working on a fix, putting it through QA, and releasing it as soon as possible, but I don’t have a timeline for when that will happen quite yet.

Also just to note, be careful with this:

Downgrading is not supported, and in some cases can cause database corruption.

That said, appreciate you doing the tests here – we’re on it and we’ll get a fix out to you as soon as possible!

Maru · May 4, 2018, 4:16am

I did the tests with a different system with no live dB. That said it should not be a problem if I just downgrade the client right?

mike · May 4, 2018, 4:34am

Correct, that’s generally going to be fine

Maru · May 4, 2018, 5:10am

Thanks for the quick confirmation. For the moment my workaround is to still have the 1.4 client available on my Mac so I can reassign the source control to other outputs for testing purposes. For other tasks I use the 1.5 client.

Andy_Spinks · May 6, 2018, 4:39pm

I’m having the same two problems:

Source Control extension selector is missing from Device Setup page (Logitech Harmony Extension)
Volume Control extension does not display correctly after selection (Denon AVR Volume Extension)

Unfortunately, I don’t have any 1.4 controllers to use as a workaround.

Thanks!

matt · May 9, 2018, 9:00am

I’m also missing the Source Control selector, using the DocBobo Logitech Harmony Extension.

Maru · May 9, 2018, 9:04am

This is a general issue affecting all node extensions right now and will hopefully be fixed in the next build. As a workaround you can still use an 1.4 client to make the neccessary configuration changes.

matt · May 10, 2018, 3:50pm

Thanks for the tip. Do you know if it’s possible to download a 1.4 client anywhere?

mike · May 10, 2018, 4:10pm

Downgrading in Roon is a bad idea, and is not supported.

That said, we released a fix for this bug last night. Give it a shot and let us know how it goes.

Maru · May 10, 2018, 4:17pm

Thanks build 323 fixed the issue.

mike · May 10, 2018, 4:33pm

Thanks for letting us know @Maru!

Also, just to note, regarding the title of this thread – starting in 1.5, we only show the External Source Controls in Device Setup when you have source control configured.

Let us know if you’re still having a problem @Andy_Spinks @matt and we can look at this for you. Thanks!

matt · May 10, 2018, 10:37pm

It’s working for me. Thanks for the quick fix.